Skip to content

feat: add constants/float16/fourth-root-eps #9610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aryan7071 wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

feat: add constants/float16/fourth-root-eps #9610

aryan7071 wants to merge 6 commits into from
+460 −0

Conversation

@aryan7071
Copy link
Contributor

@aryan7071 aryan7071 commented Jan 7, 2026

type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes. report:

  • task: lint_filenames status: passed
  • task: lint_editorconfig status: passed
  • task: lint_markdown status: passed
  • task: lint_package_json status: passed
  • task: lint_repl_help status: passed
  • task: lint_javascript_src status: passed
  • task: lint_javascript_cli status: na
  • task: lint_javascript_examples status: passed
  • task: lint_javascript_tests status: passed
  • task: lint_javascript_benchmarks status: na
  • task: lint_python status: na
  • task: lint_r status: na
  • task: lint_c_src status: na
  • task: lint_c_examples status: na
  • task: lint_c_benchmarks status: na
  • task: lint_c_tests_fixtures status: na
  • task: lint_shell status: na
  • task: lint_typescript_declarations status: passed
  • task: lint_typescript_tests status: passed
  • task: lint_license_headers status: passed ---

Description

What is the purpose of this pull request?

This pull request:

  • add constants/float16/fourth-root-eps

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@aryan7071
feat: add @stdlib/constants/float16/fourth-root-eps
0809ce2 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Jan 7, 2026
@aryan7071
feat: add @stdlib/constants/float16/fourth-root-eps
f3a7bbc 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 7, 2026 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
constants/float16/fourth-root-eps $\color{green}53/53$
$\color{green}+0.00%$ 		$\color{green}1/1$
$\color{green}+0.00%$ 		$\color{green}0/0$
$\color{green}+0.00%$ 		$\color{green}53/53$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

@Planeshifter Planeshifter changed the title feat: add @stdlib/constants/float16/fourth-root-eps feat: add constants/float16/fourth-root-eps Jan 8, 2026
@Neerajpathak07
Copy link
Member

Neerajpathak07 commented Jan 8, 2026

@aryan7071 Left a few comments. Also, do double check if the return value fits the half-precision limit.

@Neerajpathak07
Copy link
Member

Neerajpathak07 commented Jan 8, 2026 •
edited
Loading

Ohh turns out this package has been worked on in #9250.

@Neerajpathak07 Neerajpathak07 added the Potential Duplicate There might be another pull request resolving the same issue. label Jan 8, 2026
@Neerajpathak07 Neerajpathak07 mentioned this pull request Jan 8, 2026
Open
7 tasks
@aryan7071
Copy link
Contributor Author

aryan7071 commented Jan 8, 2026

Oh okay, @Neerajpathak07. In that case, I’ll close this for now. That PR is already 20 days old if it doesn’t move forward, I’d be happy to make the changes and commit them. Your call.

@stdlib-bot stdlib-bot removed the Potential Duplicate There might be another pull request resolving the same issue. label Jan 9, 2026
@aryan7071
Copy link
Contributor Author

aryan7071 commented Jan 11, 2026

@Neerajpathak07 It seems that the related PR isn’t moving forward. Should I take this up?

@aryan7071
fix: refine float16 fourth-root-eps tests and docs
a81b32e 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@aryan7071
fix: refine float16 fourth-root-eps tests and docs
9586415 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@aryan7071 aryan7071 mentioned this pull request Jan 13, 2026
Open
@aryan7071
Copy link
Contributor Author

aryan7071 commented Jan 14, 2026

@Neerajpathak07 Whenever you have the time, I’d really appreciate it if you could review this PR.

Neerajpathak07
Neerajpathak07 suggested changes Jan 16, 2026
View reviewed changes
Copy link
Member

@Neerajpathak07 Neerajpathak07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aryan7071 Overall looks in good shape, Just a few comments more to the finish line.

lib/node_modules/@stdlib/constants/float16/fourth-root-eps/test/test.js Outdated
t.end();
});

tape( 'the exported value equals the fourth root of half-precision floating-point epsilon', function test( t ) {
Copy link
Member

@Neerajpathak07 Neerajpathak07 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tape( 'the exported value equals the fourth root of half-precision floating-point epsilon', function test( t ) {
tape( 'the exported value equals the fourth root of the difference between one and the smallest value greater than one which is representable as a stdlib_float16_t (2**-10)', function test( t ) {

lib/node_modules/@stdlib/constants/float16/fourth-root-eps/test/test.js Outdated
});

tape( 'the exported value equals the fourth root of half-precision floating-point epsilon', function test( t ) {
var expected = float64ToFloat16(sqrt(sqrt(pow( 2.0, -10.0 ))));
Copy link
Member

@Neerajpathak07 Neerajpathak07 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var expected = float64ToFloat16(sqrt(sqrt(pow( 2.0, -10.0 ))));
var expected = float64ToFloat16( sqrt( sqrt( pow( 2.0, -10.0 ) ) ) );

lib/node_modules/@stdlib/constants/float16/fourth-root-eps/README.md
#include "stdlib/constants/float16/fourth_root_eps.h"
```

#### STDLIB_CONSTANT_FLOAT16_FOURTH_ROOT_EPS
Copy link
Member

@Neerajpathak07 Neerajpathak07 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to add the C header file for this given that we now have extended support for H_H macro?
cc:- @kgryte

Copy link
Contributor Author

@aryan7071 aryan7071 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay understood!

@aryan7071
fix: update float16 fourth-root-eps documentation
1520f85 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: passed
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@aryan7071
fix: update float16 fourth-root-eps documentation
811b7c8 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Neerajpathak07 Neerajpathak07 Awaiting requested review from Neerajpathak07

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Needs Review A pull request which needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aryan7071 @stdlib-bot @Neerajpathak07